[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the OpenSSF Scorecard Badge #10338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshitasao
Copy link

This PR adds OpenSSF Scorecard Badge in the README file.

The project already has the Scorecard GitHub Action running, so adding the scorecard badge would be quite handy. So that the results can be shown as a badge in the repository's README. This badge serves as a quick indicator of the project's security posture, helping users and contributors evaluate the project's security practices quickly.

Signed-off-by: harshitasao <harshitasao@gmail.com>
@k8s-ci-robot
Copy link

Hi @harshitasao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -6,6 +6,7 @@
[![Nightlies](https://github.com/containerd/containerd/workflows/Nightly/badge.svg)](https://github.com/containerd/containerd/actions?query=workflow%3ANightly)
[![Go Report Card](https://goreportcard.com/badge/github.com/containerd/containerd/v2)](https://goreportcard.com/report/github.com/containerd/containerd/v2)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/1271/badge)](https://bestpractices.coreinfrastructure.org/projects/1271)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/containerd/containerd/badge)](https://api.securityscorecards.dev/projects/github.com/containerd/containerd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking the link takes me to the api. subdomain, which is not human-readable; should that be a different subdomain? https://api.securityscorecards.dev/projects/github.com/containerd/containerd

@dmcgowan
Copy link
Member

We didn't have this added previously because the scoring system was buggy. It seems much of that is fixed but still see a couple errors in the score based on https://scorecard.dev/viewer/?uri=github.com/containerd/containerd. We have already followed the guidance for "Token-Permissions" yet the score is 0 and does not match the documentation remediation steps. How is it supposed to check branch protection, we have that in place but not something that would be accessible to view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants