Async Signer: add support for async OCSP call #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42f81c4
to
72e784e
Compare
72e784e
to
655f6c0
Compare
gpeacock
approved these changes
Apr 25, 2024
| @@ -204,7 +204,12 @@ fn build_headers(signer: &dyn Signer, data: &[u8], alg: SigningAlg) -> Result<(H | |||
| }; | |||
|
|
|||
| let certs = signer.certs()?; | |||
| let ocsp_val = signer.ocsp_val(); | |||
|
|
|||
| let ocsp_val = if _sync { | |||
There was a problem hiding this comment.
This makes me think I should (someday) update async_generic to trim away the .await clause in the synchronous case. (Not going to happen soon, sadly.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Updates ocsp_val in async signer to be async
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.