(PATCH) ensures temp files are removed #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
679f543
to
ab13997
Compare
redsubmarine
pushed a commit
to yangoneseok/c2pa-rs
that referenced
this pull request
Jul 2, 2024
* 'nightly' of github.com:contentauth/c2pa-rs: Prepare 0.32.5-nightly+2024-07-02-21fd0e0 release Prepare 0.32.5 release (PATCH) ensures temp files are removed (contentauth#494) Update async_generic to 1.1 (contentauth#493) Prepare 0.32.4 release # Conflicts: # Cargo.lock # sdk/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This PR changes the behavior of the
asset_io::rename_or_copyfunction by deleting the copied file after it has been copied to the destination path.This mainly affected our windows clients as the
std::fs::renamefails when renaming a file from one drive to another drive on windows.The new behavior is the following:
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.