-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs welcome page and Development / Inference page overhaul #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! r+ with comments addressed.
doc/DEPLOYMENT.rst
Outdated
* :ref:`The Node.JS package + language binding <nodejs-usage>` | ||
* :github:`The .NET client + language binding <native_client/dotnet/README.rst>` | ||
|
||
Download trained 🐸STT models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using the policy of expanding 🐸 -> Coqui in headings in the docs.
doc/SUPPORTED_PLATFORMS.rst
Outdated
|
||
Here we maintain the list of supported platforms for running inference. Note that for now we only have working packages for Python on Linux, without GPU support. We're working to get the rest of our supported languages and architectures up and running. | ||
Here we maintain the list of supported platforms for running inference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consistent on deployment/inference throughout the docs.
doc/index.rst
Outdated
|
||
BUILDING_DotNet | ||
The fastest way to deploy a pre-trained 🐸STT model is with `pip`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should retain the note about Linux only support for now here to avoid people running into missing packages as after following the first explicit step-by-step instructions in our docs.
doc/index.rst
Outdated
|
||
Scorer | ||
# Create a virtual environment | ||
$ python -m venv venv-stt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ python -m venv venv-stt | |
$ python3 -m venv venv-stt |
We don't support Python 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bare python
executable is still Python 2 on lots of running systems. That's also up to the distro and not Python.org's support timeline. So it's better to be safe here and explicitly create the venv with the Python 3 executable.
doc/DEPLOYMENT.rst
Outdated
|
||
.. code-block:: | ||
|
||
(coqui-stt-venv)$ python -m pip install stt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(coqui-stt-venv)$ python -m pip install stt | |
(coqui-stt-venv)$ pip install -U pip && pip install stt |
doc/DEPLOYMENT.rst
Outdated
|
||
After installation has finished, you can call ``stt`` from the command-line. | ||
|
||
The following command assumes you `downloaded the pre-trained models <#getting-the-pre-trained-model>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct way to reference sections in RST is by giving them a name, so that this link doesn't break if you change the section heading. See for example the py-usage
section name above or py-api-example
just below.
doc/DEPLOYMENT.rst
Outdated
|
||
Alternatively you may manually download the ``native_client.tar.xz`` from the `releases page <https://github.com/coqui-ai/STT/releases>`_. | ||
|
||
Assuming you have `downloaded the pre-trained models <#getting-the-pre-trained-model>`_, you can use the client as such: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a proper section name for linking.
|
||
See :ref:`the Python client <py-api-example>` for an example of how to use the package programatically. | ||
|
||
*GPUs will soon be supported:* If you have a supported NVIDIA GPU on Linux, you can install the GPU specific package as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding a note about missing GPU support here then should we also add a note about missing JS support in the JS docs? And missing GPU support in the GPU docs for JS?
doc/DEPLOYMENT.rst
Outdated
Installing bindings from source | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
If pre-built binaries aren't available for your system, you'll need to install them from scratch. Follow the :github:`native client build and installation instructions <native_client/README.rst>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is broken, should be:
If pre-built binaries aren't available for your system, you'll need to install them from scratch. Follow the :github:`native client build and installation instructions <native_client/README.rst>`. | |
If pre-built binaries aren't available for your system, you'll need to install them from scratch. Follow the :github:`native client build and installation instructions <build-native-client>`. |
This is a purely document-related PR
index.rst
)DEPLOYMENT.rst