[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotnet client to support netstandard2.0, netstandard2.1, net5.0 and net6.0 #2271

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Update dotnet client to support netstandard2.0, netstandard2.1, net5.0 and net6.0 #2271

merged 2 commits into from
Jul 28, 2022

Conversation

stepkillah
Copy link
Contributor

Migrate to netstandard2.0 and add support for net5.0, net6.0
Also, I updated net461 to net48 because 4.6.1 is out of support

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

@stepkillah
Migrate to net framework 4.8
6353667 
Migrate to netstandard2.0 and add support for net5.0, net6.0
@CLAassistant
Copy link
CLAassistant commented Jul 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@reuben
Copy link
Collaborator
reuben commented Jul 27, 2022

Thanks for the PR!

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

We do not. The .NET CI is still missing from the GitHub Actions transition.

@stepkillah
Copy link
Contributor Author

Thanks for the PR!

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

We do not. The .NET CI is still missing from the GitHub Actions transition.

I can try to add ones in this or better in separate PR later

@reuben
Copy link
Collaborator
reuben commented Jul 27, 2022

That'd be fantastic!

@reuben
Copy link
Collaborator
reuben commented Jul 27, 2022

Looks like there are some linter errors, could you set-up the linter and run it on your files? You should be able to run python .pre-commit-2.11.1.pyz run --all-files to have it fix the problem for you, then git commit --amend and force push.

@stepkillah
Copy link
Contributor Author
stepkillah commented Jul 27, 2022 •
edited
Loading

@reuben sorry, missed to do amend and did another commit :(

@reuben reuben merged commit 2e8b0ba into coqui-ai:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stepkillah @CLAassistant @reuben