reconciler/managed: keep trying to update critical annotation until c…

…tx canceled Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
crossplane · Jan 27, 2024 · 7d7a4e9 · 7d7a4e9
1 parent f4310f0
commit 7d7a4e9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/reconciler/managed/api.go b/pkg/reconciler/managed/api.go
@@ -212,7 +212,9 @@ func NewRetryingCriticalAnnotationUpdater(c client.Client) *RetryingCriticalAnno
 // case of a conflict error.
 func (u *RetryingCriticalAnnotationUpdater) UpdateCriticalAnnotations(ctx context.Context, o client.Object) error {
 	a := o.GetAnnotations()
-	err := retry.OnError(retry.DefaultRetry, resource.IsAPIError, func() error {
+	err := retry.OnError(retry.DefaultRetry, func(err error) bool {
+		return !errors.Is(err, context.Canceled)
+	}, func() error {
 		err := u.client.Update(ctx, o)
 		if kerrors.IsConflict(err) {
 			if getErr := u.client.Get(ctx, client.ObjectKeyFromObject(o), o); getErr != nil {