This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Change default service type to ClusterIP #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodePort might be useful for some demos (especially with minikube), but it isn't a great default for all scenarios. ClusterIP is a safer default, and you can always forward a port to it if you don't have ingress. Signed-off-by: Dave Syer <dsyer@vmware.com>
wonderflow
approved these changes
Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePort might be useful for some demos (especially with minikube),
but it isn't a great default for all scenarios. ClusterIP is a
safer default, and you can always forward a port to it if you
don't have ingress.
As discussed on slack, here is a PR to change the default service
type. Eventually I guess this would be a trait, but for now I
just switch the default.