[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESlint and Conform Apps & Packages #589

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7534bba
use RSCs in @dub/ui
versecafe Jan 19, 2024
e3d5016
remove accidental temp comment from readme
versecafe Jan 19, 2024
9dd7fed
final UI component that can be moved
versecafe Jan 20, 2024
c6aa72f
clean unused code and document change
versecafe Jan 20, 2024
7ce96c1
typo cleanup
versecafe Jan 20, 2024
16a75db
Merge branch 'dubinc:main' into use-rscs-in-ui-package
versecafe Jan 20, 2024
469bf4f
eslitn package + configs set up
versecafe Jan 29, 2024
698d09a
partial packages eslint conformance
versecafe Jan 29, 2024
dffc46c
Merge branch 'main' into eslint
versecafe Jan 29, 2024
71725e5
Merge branch 'main' into pr/572
steven-tey Jan 30, 2024
fc51c6b
Merge branch 'use-rscs-in-ui-package' of https://github.com/versecafe…
steven-tey Jan 30, 2024
bcadf64
Update pnpm-lock.yaml
steven-tey Jan 30, 2024
e825fe8
small fixes
steven-tey Jan 30, 2024
cfe62fb
Merge branch 'main' into eslint
versecafe Feb 4, 2024
d19b356
fix lockfile
versecafe Feb 4, 2024
a053826
turbo.json fix caching behaviour for env var update, and fix minor er…
versecafe Feb 4, 2024
f33ee0a
Merge branch 'dubinc:main' into use-rscs-in-ui-package
versecafe Feb 4, 2024
5a6c03a
Merge branch 'temp-test' into eslint
versecafe Feb 4, 2024
be1f9a2
Revert "Merge branch 'temp-test' into eslint"
versecafe Feb 4, 2024
405c271
fix pnpm lock
versecafe Feb 5, 2024
3eccb0a
further compliance ui from 82 to 57 problems
versecafe Feb 5, 2024
e78d84f
minor cleaning
versecafe Feb 5, 2024
8b13f90
clean web to bring conformance up
versecafe Feb 5, 2024
b5b77a9
Merge branch 'main' into eslint
versecafe Feb 5, 2024
6768190
fix up lockfile
versecafe Feb 5, 2024
63246e6
Merge branch 'main' into eslint
versecafe Feb 6, 2024
141d4fb
Merge branch 'main' into eslint
versecafe Feb 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"clean": "turbo clean",
"format": "prettier --write \"**/*.{ts,tsx,md}\"",
"publish-tw": "turbo build --filter='@dub/tailwind-config' && cd packages/tailwind-config && npm publish && cd ../../",
"publish-ui": "turbo build --filter='@dub/ui' && cd packages/ui && npm publish && cd ../../",
"publish-ui": "cd packages/ui && npm publish && cd ../../",
"publish-utils": "turbo build --filter='@dub/utils' && cd packages/utils && npm publish && cd ../../",
"script": "echo 'Run this script in apps/web'"
},
Expand Down
15 changes: 15 additions & 0 deletions packages/ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,18 @@ To install the package, run:
```bash
pnpm i @dub/ui
```

### Transpiling

As of version `0.1.0` the package is not bundled, this means transpiling the module is
highly recommended, this was done to support React Server Components.

If you are using NextJS this is as simple as:

```js
// next.config.js
/** @type {import('next').NextConfig} */
module.exports = {
transpilePackages: ["@dub/ui"]
}
```
2 changes: 0 additions & 2 deletions packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"types": "./src/index.tsx",
"scripts": {
"lint": "eslint src/",
"dev": "tsup --watch",
"check-types": "tsc --noEmit"
},
"peerDependencies": {
Expand All @@ -26,7 +25,6 @@
"react": "^18.2.0",
"tailwindcss": "^3.3.3",
"tsconfig": "workspace:*",
"tsup": "^6.1.3",
"typescript": "^5.1.6"
},
"dependencies": {
Expand Down
2 changes: 0 additions & 2 deletions packages/ui/src/button.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
"use client";

import { cn } from "@dub/utils";
import { ReactNode } from "react";
import { LoadingSpinner } from "./icons";
Expand Down
15 changes: 0 additions & 15 deletions packages/ui/tsup.config.ts

This file was deleted.