interim: interim commit of the generate function #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
- Need to remove non-empty directories during tests.
- Need to check all test projects for adaptive icons.
- Can simplify test patterns for normal icon generation to match what is done for adaptive (and should do for consistency).
- Fix bug: 'anydpi' adaptive icons are not rendered correctly #89
1. Need to remove non-empty directories during tests. 2. Need to check all test projects for adaptive icons. 3. Can simplify test patterns for normal icon generation to match what is done for adaptive (and should do for consistency).
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 96.04% 96.61% +0.57%
==========================================
Files 15 17 +2
Lines 177 207 +30
==========================================
+ Hits 170 200 +30
Misses 7 7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
+ Coverage 96.04% 96.84% +0.8%
=========================================
Files 15 17 +2
Lines 177 222 +45
=========================================
+ Hits 170 215 +45
Misses 7 7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.