[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open in IDX feature #2995

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Add Open in IDX feature #2995

merged 5 commits into from
Jun 12, 2024

Conversation

johnpryan
Copy link
Contributor

This adds an API endpoint and UI component to open the current snippet in IDX under the new "Continue in" dropdown.

closes #2984

Screenshot 2024-06-12 at 9 31 45 AM

@devoncarew
Copy link
Member

For the UI:

  • consider move the "open external" icon from the 'Install SDK' menu item to the 'continue in' menu; this would parallel the 'new' and 'samples' menus
  • as the IDX and Install SDK menu items take you somewhere, consider ending them in ellipses (…)

@devoncarew
Copy link
Member

I wonder if the 'Install SDK' menu item should move from the continue in menu to the tripple dot overflow menu? It's a different type of action than the IDX one; it doesn't use any of the content of the current snippet.

fwiw, I do like having a 'continue in' menu to hold the IDX item

Copy link
Member
@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the menu presentation, and about how we're forming the http POST.

@johnpryan
Copy link
Contributor Author

consider move the "open external" icon from the 'Install SDK' menu item to the 'continue in' menu; this would parallel the 'new' and 'samples' menus

This indicates that pressing the button will take you somewhere (at least that's how I interpret it). When I add this, it looks odd to me:

Screenshot 2024-06-12 at 10 41 09 AM

as the IDX and Install SDK menu items take you somewhere, consider ending them in ellipses

I'm not familiar with this pattern, to me it would be weird to have two sets of elipses, "Open in... -> IDX... Install SDK..."

I wonder if the 'Install SDK' menu item should move from the continue in menu to the tripple dot overflow menu? It's a different type of action than the IDX one; it doesn't use any of the content of the current snippet.

Right now we struggle with maintaining so many menu buttons. (For the mobile layout we need hide this button, for example). I'd rather group these together. If there's a dropdown with only one option, that doesn't really add much value to the UI, since it could have just been a button in the first place.

@johnpryan
Copy link
Contributor Author

Discussed offline, final result:

Screenshot 2024-06-12 at 10 58 15 AM

@johnpryan johnpryan merged commit f12269f into dart-lang:main Jun 12, 2024
7 checks passed
@romannurik
Copy link

Awesome that this is live!! @johnpryan one quick note, I noticed the "Flame game" sample doesn't work as-is because the pubspec.yaml (with the flame package) isn't being sent along... let me know if that's challenging to send across.

@johnpryan
Copy link
Contributor Author

Thanks for finding that @romannurik, we should be able to fix this. I filed an issue to track: #3005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Continue in" feature
3 participants