[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix package name when refreshing binstubs #55373

Closed
sigurdm opened this issue Apr 4, 2024 · 3 comments
Closed

[CP] Fix package name when refreshing binstubs #55373

sigurdm opened this issue Apr 4, 2024 · 3 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve dart-cli-pub Issues related to the 'dart pub' tool dependencies Pull requests that update a dependency file

Comments

@sigurdm
Copy link
Contributor
sigurdm commented Apr 4, 2024

Commit(s) to merge

dart-lang/pub#4205
Was rolled to sdk main in https://dart-review.googlesource.com/c/sdk/+/361061

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/361102

Issue Description

dart pub global run would (under some circumstances) rewrite binstubs with bad contents. Making them unrunable.

What is the fix

Write the correct binstub instead of the broken one.

Why cherry-pick

This potentially affects all users of pub binstubs

Risk

Medium-Low

Issue link(s)

dart-lang/pub#4206

Extra Info

No response
@sigurdm sigurdm added the cherry-pick-review Issue that need cherry pick triage to approve label Apr 4, 2024
@sigurdm sigurdm changed the title [CP] <title> [CP] Fix package name when refreshing binstubs Apr 4, 2024
@lrhn lrhn added area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-pub Issues related to the 'dart pub' tool dependencies Pull requests that update a dependency file labels Apr 4, 2024
@itsjustkevin
Copy link
Contributor

@jonasfj and @athomas can you take a look at this cherry-pick?

@athomas
Copy link
Member
athomas commented Apr 16, 2024

LGTM, small localized change with test coverage.

@jonasfj
Copy link
Member
jonasfj commented Apr 16, 2024

LGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Apr 16, 2024
copybara-service bot pushed a commit that referenced this issue Apr 16, 2024
@sigurdm
[beta] Bump pub to ed20b45589766d6fd135e93460b9e8255ccba519
b593783 
Changes:
```
> git log --format="%C(auto) %h %s" 3f0df78..ed20b45
 https://dart.googlesource.com/pub.git/+/ed20b455 Fix package name when refreshing binstubs (4205)

```

Diff: https://dart.googlesource.com/pub.git/+/3f0df78417f7c112b933fbcdc1c5c87bde680cb1..ed20b45589766d6fd135e93460b9e8255ccba519/
Bug: dart-lang/pub#4206
Change-Id: I9c46f08f46b159d864a4b72c08673fe5f20d8886
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/361061
Cherry-pick-request: #55373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361102
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve dart-cli-pub Issues related to the 'dart pub' tool dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jonasfj @vsmenon @lrhn @sigurdm @itsjustkevin @mit-mit @athomas