-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect hrefs that use target="_blank" without noopener #176
Comments
Same issue on webdev: https://github.com/dart-lang/site-webdev/issues/154 |
(I had added the file in the original via drag/drop but didn't notice that it required a file extension. So adding the file again.) |
As of 2020/2/14, we still have up to 44 instances on dart.dev:
OLD:
So up to 44 instances, but many of those are to the same site or to dartlang.org sites, and I'm not sure noopener matters for those. |
I think that the best solution would be to have a Jekyll plugin to handle this. (The same plugin would be useful to address issues with punctuation and the "external link" icon.) |
I think that 'issues with punctuation and the "external link" icon' refers to the fact that we have to include the punctuation inside the link in order for the external link icon not to move the punctuation so far to the right that it looks weird. So we end up with a lot of, say, Is that right, @chalin? Did you have a specific solution in mind for that? |
Yes, that's it.
A Jekyll plugin. |
Related: #1058 |
I'm just going to apply this fix by hand. |
...and sometimes just delete the _blank. Contributes to #176.
Perhaps we should have a test for _blanks without noopener? |
For performance and security reasons:
https://jakearchibald.com/2016/performance-benefits-of-rel-noopener/
We need a macro for this site and for webdev.
I found 86 instances on www.
The text was updated successfully, but these errors were encountered: