[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add repo link in databend-common-ast lib #16010

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore: add repo link in databend-common-ast lib #16010

merged 1 commit into from
Jul 10, 2024

Conversation

lewiszlw
Copy link
Contributor
@lewiszlw lewiszlw commented Jul 10, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

I suggest people to take a look at this lib, and found no link to the github repo in crates.io, so added it.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): package link

This change is Reviewable

@lewiszlw lewiszlw changed the title Add repo link in databend-common-ast lib chore: add repo link in databend-common-ast lib Jul 10, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request's title is not fulfill the requirements. @lewiszlw please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@BohuTANG BohuTANG merged commit de689a3 into datafuselabs:main Jul 10, 2024
79 of 86 checks passed
@lewiszlw lewiszlw deleted the patch-1 branch July 10, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lewiszlw @sundy-li @BohuTANG