[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add pre-commit hooks #24

Merged
merged 7 commits into from
Jul 1, 2024
Merged

chore: add pre-commit hooks #24

merged 7 commits into from
Jul 1, 2024

Conversation

Amnah199
Copy link
Contributor

Related Issues

Proposed Changes:

Adds pre-commit hooks to the repo

How did you test it?

Manual testing

Notes for the reviewer

Checklist

@Amnah199 Amnah199 requested a review from a team as a code owner June 27, 2024 16:18
@Amnah199 Amnah199 requested review from shadeMe and removed request for a team June 27, 2024 16:18
@coveralls
Copy link
coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9700103224

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.562%
Totals Coverage Status
Change from base Build 9697814678: 0.0%
Covered Lines: 1682
Relevant Lines: 1837
💛 - Coveralls

@Amnah199 Amnah199 requested review from vblagoje and removed request for shadeMe June 27, 2024 16:28
@vblagoje
Copy link
Member

@Amnah199 once you update branch (button below right) you should not see integration test failures

@coveralls
Copy link
coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9711268561

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.562%
Totals Coverage Status
Change from base Build 9697814678: 0.0%
Covered Lines: 1682
Relevant Lines: 1837
💛 - Coveralls

@coveralls
Copy link
coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9711352546

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.562%
Totals Coverage Status
Change from base Build 9697814678: 0.0%
Covered Lines: 1682
Relevant Lines: 1837
💛 - Coveralls

@coveralls
Copy link
coveralls commented Jun 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9732240191

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.562%
Totals Coverage Status
Change from base Build 9697814678: 0.0%
Covered Lines: 1682
Relevant Lines: 1837
💛 - Coveralls

@coveralls
Copy link
coveralls commented Jun 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9732281453

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.562%
Totals Coverage Status
Change from base Build 9697814678: 0.0%
Covered Lines: 1682
Relevant Lines: 1837
💛 - Coveralls

vblagoje
vblagoje approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member
@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would you please throw a quick glance as well @silvanocerza ?

silvanocerza
silvanocerza approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor
@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@vblagoje vblagoje merged commit df88e3e into main Jul 1, 2024
5 checks passed
@vblagoje vblagoje deleted the add-pre-commit-hooks branch July 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Amnah199 @coveralls @vblagoje @silvanocerza