[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disable OpenAPITool firecrawl integration test #26

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: Disable OpenAPITool firecrawl integration test #26

merged 1 commit into from
Jul 1, 2024

Conversation

vblagoje
Copy link
Member
@vblagoje vblagoje commented Jul 1, 2024

Firecrawl servers repeatedly hit read timeouts, most likely due to popularity of this service and insufficient capacity on their side. Disable for now continue to run manually, revisit in a month or so

@vblagoje vblagoje requested a review from a team as a code owner July 1, 2024 10:07
@vblagoje vblagoje requested review from davidsbatista and shadeMe and removed request for a team July 1, 2024 10:07
@coveralls
Copy link
coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9742288426

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 28 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 90.044%
Files with Coverage Reduction New Missed Lines %
haystack_experimental/components/tools/openapi/_schema_conversion.py 2 90.09%
test/components/tools/openapi/conftest.py 3 84.62%
haystack_experimental/components/tools/openapi/_openapi.py 8 70.15%
test/components/tools/openapi/test_openapi_client_live_openai.py 15 58.0%
Totals Coverage Status
Change from base Build 9742193369: -1.5%
Covered Lines: 1655
Relevant Lines: 1838
💛 - Coveralls

@vblagoje vblagoje changed the title chore: Disable Firecrawl integration test chore: Disable OpenAPITool firecrawl integration test Jul 1, 2024
@vblagoje vblagoje merged commit e1b0ae2 into main Jul 1, 2024
5 checks passed
@vblagoje vblagoje deleted the disable_firecrawl branch July 1, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

@davidsbatista davidsbatista Awaiting requested review from davidsbatista davidsbatista is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vblagoje @coveralls @shadeMe