[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no longer load full table into ram in write #2265

Closed
wants to merge 24 commits into from
Closed

feat: no longer load full table into ram in write #2265

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
565f43d
close to compiling
aersam Mar 7, 2024
3a52bb7
still learning :)
aersam Mar 8, 2024
30a5463
some compile errors
aersam Mar 8, 2024
cde4207
another bug fix
aersam Mar 8, 2024
6743373
clippy feedback
aersam Mar 8, 2024
577442b
test compilation
aersam Mar 8, 2024
4b276a7
wip on tests
aersam Mar 8, 2024
9d022cb
Merge branch 'main' of https://github.com/aersam/delta-rs into write-…
aersam Mar 8, 2024
d1352fa
Merge branch 'main' of https://github.com/aersam/delta-rs into write-…
aersam Mar 11, 2024
d4d82ce
cleanup
aersam Mar 11, 2024
385c935
wip on fixes
aersam Mar 11, 2024
023df09
more fixes
aersam Mar 11, 2024
0397a0c
more fixes
aersam Mar 11, 2024
c83f947
fmt
aersam Mar 11, 2024
f131eb1
adjust test
aersam Mar 11, 2024
a3d5585
use into()
aersam Mar 12, 2024
965968c
we need GIL, no?
aersam Mar 13, 2024
83d398f
clippy, your so right
aersam Mar 13, 2024
98bf7ec
revert 965968cda0d3d6cace62905b5af5437960ea851a and 965968cda0d3d6cac…
aersam Mar 13, 2024
44cd5b9
Merge branch 'main' into write-iter2
aersam Mar 13, 2024
5ae3599
Merge branch 'main' of https://github.com/aersam/delta-rs into write-…
aersam Mar 14, 2024
28eba65
fmt
aersam Mar 14, 2024
c66762a
Merge branch 'write-iter2' of https://github.com/aersam/delta-rs into…
aersam Mar 14, 2024
6e742a9
Merge branch 'main' of https://github.com/aersam/delta-rs into write-…
aersam Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy, your so right
  • Loading branch information
@aersam
aersam committed Mar 13, 2024
commit 83d398f82087b7c56db9b1fc7d35530617e3cdd7
4 changes: 2 additions & 2 deletions python/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,13 +1389,13 @@ struct GilIterator {
reader: ArrowArrayStreamReader,
}

impl<'a> Iterator for GilIterator {
impl Iterator for GilIterator {
type Item = RecordBatch;

fn next(&mut self) -> Option<Self::Item> {
let reader = &mut self.reader;

Python::with_gil(|_| reader.next().map_or(None, |v| Some(v.unwrap())))
Python::with_gil(|_| reader.next().map(|v| v.unwrap()))
}
}

Expand Down
Loading