[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #693 - Fix issue with vuestorefront having wrong folder name #765

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

Thomas-Boi
Copy link
Member

This should fixes #693.

Git doesn't track capital-sensitivity in file paths, thus a simple file name changes locally doesn't fix it. This PR basically removes the folder in one commit and restore it in a different name in another, hopefully causes git to track it.

Copy link
Member
@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git doesn't track capital-sensitivity in file paths

yep, I had this problem in other projects as well.. You came up with a solution, I will use it in some other cases 👍🏻

Copy link
Member
@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out and for the fix. 🙂

@Panquesito7 Panquesito7 added bug Use this label for pointing out bugs and removed enhancement labels Jul 21, 2021
@Thomas-Boi
Copy link
Member Author

I'll merge this in. The icons are still the same so this won't show up in the build release

@Thomas-Boi Thomas-Boi merged commit 5c1d3d5 into develop Jul 21, 2021
@Panquesito7 Panquesito7 deleted the thomas/fixvuestorefront branch July 21, 2021 21:30
@Panquesito7 Panquesito7 linked an issue Aug 6, 2021 that may be closed by this pull request
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: svg file of "vuestorefront" not exist.
3 participants