[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: check-svg-bot upgrade #807

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

Thomas-Boi
Copy link
Member
@Thomas-Boi Thomas-Boi commented Aug 13, 2021

Hello guys,

This PR contains upgrades to the check-svg bot. The bot will now:

  • Not check for <style> tags in the SVG. Since the optimizer bot will prefix the classes with the file's name, the class name will be unique from now on => avoid issues of clashing class names from using multiple SVGs inline within HTML.
  • Check for stroke-width in the property and styles of the elements. After some testing, I found that Icomoon will warn us about strokes based on the presence of the stroke-width property/style.

Test: N/A

EDIT: I've removed the stroke-width check. Having it in would require refactoring the script to almost similar as peek-bot. I think having peek-bot checking for strokes should be enough. Let me know what you guys think. If you think having check-svg warn them is better (since it's earlier), let me know.

@Thomas-Boi Thomas-Boi force-pushed the thomas/feature/checkSvgUpdate branch from 330af58 to 8628380 Compare August 13, 2021 05:42
@Thomas-Boi Thomas-Boi added devops Use this label for devops related enhancements enhancement labels Aug 13, 2021
Copy link
Member
@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Thomas-Boi.

@Thomas-Boi Thomas-Boi merged commit e5aa8a9 into develop Aug 13, 2021
@Panquesito7 Panquesito7 deleted the thomas/feature/checkSvgUpdate branch August 13, 2021 18:51
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants