feat: removed inception dependency for installation. #3228
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| - name: PG_PASSWORD | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ $.Values.lens.dbconfig.secretName }} |
There was a problem hiding this comment.
This should be gitsensor.dbconfig
| terminationGracePeriodSeconds: 120 | ||
| containers: | ||
| - name: nats | ||
| image: nats:2.9.3-alpine |
There was a problem hiding this comment.
Drive this image from values.yaml
There was a problem hiding this comment.
Remove these charts
There was a problem hiding this comment.
Chart.lock file shouldn't be commited
| @@ -8,20 +8,21 @@ global: | |||
| runAsUser: 1000 | |||
| runAsNonRoot: true | |||
| installer: | |||
| repo: "devtron-labs/devtron" | |||
| repo: "jatin-jangir/devtron" | |||
There was a problem hiding this comment.
change it back to devtron-labs
| # For Kubernetes version < 1.16, set release: legacy. You won't be able to upgrade Devtron unless you upgrade the K8s version to 1.16 or above. | ||
| release: "v0.6.14" #You can use a branch name or a release tag name as a release, for gitee as source only "main" is supported as of now | ||
| release: "remove-kubewatch" #You can use a branch name or a release tag name as a release, for gitee as source only "main" is supported as of now |
There was a problem hiding this comment.
Same goes here - change it back
| image: quay.io/devtron/inception | ||
| tag: 44b30917-185-13275 | ||
| source: "github" # Available options are github and gitee | ||
| # mode: "dashboard" # Available options are dashboard, full and hyperion (deprecated) NOT USING THIS | ||
| modules: [] # Available options are cicd | ||
| modules: | ||
| - "cicd" # Available options are cicd |
There was a problem hiding this comment.
Do not add any modules by default
| production_overrides: "" # Set true if you want to use this Devtron stack in Production (This will require more resources) | ||
|
|
||
| # Change the below values for full mode only | ||
|
|
||
| #Use secrets in plaintext, they'll be encoded to base64 automatically. | ||
| secrets: {} | ||
| secrets: |
There was a problem hiding this comment.
Why this change is required?
| @@ -277,7 +292,7 @@ security: | |||
| fullnameOverride: clair | |||
| # Values for notifier integration | |||
| notifier: | |||
| enabled: false | |||
| enabled: true | |||
There was a problem hiding this comment.
don't enable it by default
| secretName: postgresql-postgresql | ||
| keyName: postgresql-password | ||
|
|
||
| gitsensor: |
There was a problem hiding this comment.
take it inside components
| @@ -4,4 +4,4 @@ metadata: | |||
| name: installer-devtron | |||
| namespace: devtroncd | |||
| spec: | |||
| url: https://raw.githubusercontent.com/devtron-labs/devtron/v0.6.14/manifests/installation-script | |||
| url: https://raw.githubusercontent.com/jatin-jangir/devtron/remove-kubewatch/manifests/installation-script | |||
There was a problem hiding this comment.
Revert these changes too
| COMMIT_STATS_TIMEOUT_IN_SEC: "2" | ||
| dbconfig: | ||
| secretName: postgresql-postgresql | ||
| keyName: postgresql-password |
There was a problem hiding this comment.
Expose persistent size in values.yaml and keep it 2Gi as default
| name: postgresql-migrator | ||
| {{- if $.Values.components.migrator.gitsensor }} | ||
| {{- if $.Values.components.migrator.gitsensor.initContainer }} | ||
| {{- if $.Values.components.migrator.gitsensor.initContainer.resources }} |
There was a problem hiding this comment.
There's no init container in lens and gitsensor, please fix
Description
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?