[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portrait change text command doesn't work if there are any '/' characters in the portrait name #1635

Closed
klein-eng opened this issue Jul 13, 2023 · 1 comment · Fixed by #1649
Closed

Portrait change text command doesn't work if there are any '/' characters in the portrait name #1635

klein-eng opened this issue Jul 13, 2023 · 1 comment · Fixed by #1649
Assignees
@Jowan-Spooner
Labels
Approved This can be added, but is not on any roadmap yet Bug 🐞 Something isn't working
Milestone
Version 2.0 (beta)

Comments

@klein-eng
Copy link
klein-eng commented Jul 13, 2023 •
edited
Loading

The problem

Describe the bug
I would expect the following portrait change command to work:
John (CloseUp/Happy): "My expression changes [portrait=CloseUp/Sad] while speaking."
However, what actually ends up being output is:
"My expression changes CloseUp while speaking." or "My expression changes Sad while speaking."

It seems like the [option1/option2] random choice command is interfering with the portrait command when there are any '/' characters in the portrait name. Because the '/' character is used for portrait groupings, this would come up fairly often.

Expected behavior
Even if there is a '/' character in the portrait name, the example above would change John to the CloseUp/Sad portrait.

System (please complete the following information):

  • Godot Version: 4.1
  • Dialogic Version: 2.0
@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Needs testing We don't understand this problem fully yet Approved This can be added, but is not on any roadmap yet and removed Needs testing We don't understand this problem fully yet labels Jul 28, 2023
@Jowan-Spooner Jowan-Spooner self-assigned this Jul 29, 2023
@Jowan-Spooner
Copy link
Collaborator

Thank you very much for the report! Sorry for not answering for so long, I was on holiday ;). I will try to fix it now.

Jowan-Spooner added a commit that referenced this issue Jul 29, 2023
@Jowan-Spooner
Fix for #1635 and #1593 and random selection highlighting
d2ffd0a 
Random selection is now indicated like this <OptionA/OptionB>.
@Jowan-Spooner Jowan-Spooner linked a pull request Jul 29, 2023 that will close this issue
Fix for #1635 and #1593 and random selection highlighting #1649
Merged
Jowan-Spooner added a commit that referenced this issue Jul 30, 2023
@Jowan-Spooner
Fix for #1635 and #1593 and random selection highlighting (#1649)
668c7ae 
* Fix for #1635 and #1593 and random selection highlighting

Random selection is now indicated like this <OptionA/OptionB>.

* Update tip about random words

* Fix home page random tip button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jowan-Spooner Jowan-Spooner

Labels
Approved This can be added, but is not on any roadmap yet Bug 🐞 Something isn't working
Projects
None yet
Milestone
Version 2.0 (beta)
Development

Successfully merging a pull request may close this issue.

Fix for #1635 and #1593 and random selection highlighting dialogic-godot/dialogic
2 participants
@Jowan-Spooner @klein-eng