Various smaller fixes #1498
Merged
Various smaller fixes #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_save() is now called even if the editor is not of type resource. This makes sure that for examples variables are correctly saved before starting a debug game and when hitting CTRL+S.
- Also give character instead of character name in Dialogic.Text.speaking_character signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure variable editor saves when the editor saves not only when you switch editor. This resulted in a rename of _resource_saved() to just _saved() in the DialogicEditor class and thus the other dialogic Editors.
Added static tpying in a couple of places.
Added handy methods to the portrait subsystem. Also changed what is given with the Dialogic.Text.speaking_character signal (now the character resource).