-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables Rework (second PR attempt) #1972
Merged
Jowan-Spooner
merged 11 commits into
dialogic-godot:main
from
Jowan-Spooner:variables-rework
Dec 27, 2023
Merged
Variables Rework (second PR attempt) #1972
Jowan-Spooner
merged 11 commits into
dialogic-godot:main
from
Jowan-Spooner:variables-rework
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into variables
Jowan-Spooner
pushed a commit
that referenced
this pull request
Jan 18, 2024
When setting a dialogic variable in code, it showed a bug here after alpha 12. The method called _set_value_in_dictionary in outside as VariableFolder has been removed since commit Variables Rework (second PR attempt) (#1972)
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Improving new typed variables and variable editor * Remove print * Small changes and improving condition picker * Remove old variable editor scenes * Improving new typed variables and variable editor * Remove print * Small changes and improving condition picker * Remove old variable editor scenes * Small fix
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
When setting a dialogic variable in code, it showed a bug here after alpha 12. The method called _set_value_in_dictionary in outside as VariableFolder has been removed since commit Variables Rework (second PR attempt) (dialogic-godot#1972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the variables editor so you can select a variable type.
Also reworks the set variable and condition pickers to allow for easy boolean checks.