[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the Timeline Sidebar Size #2153

Merged

Conversation

CakeVR
Copy link
Collaborator
@CakeVR CakeVR commented Mar 27, 2024

When reloading the project, the right sidebar of the timeline editor does not remember its last manually set size.

This pull request saves the size as project setting, assigns the correct size to all relevant containers, and sets the proper event button style.

Closes #2152

@CakeVR CakeVR added the Enhance ⚡ Improve a feature's workflow. label Mar 27, 2024
@Jowan-Spooner
Copy link
Collaborator

@CakeVR We have our own "editor settings" for this, stuff like this should not be stored in the project settings, because it's super annoying for vcs, especially in a team.
You should use:
DialogicUtil.set_editor_setting()
DialogicUtil.get_editor_setting()

Also I'll have to take another look, but I had tried to implement this originally, but somehow it didn't work, not sure if there are any leftovers from that attempt.

@CakeVR
Copy link
Collaborator Author
CakeVR commented Mar 27, 2024

Thanks a lot, I use DialogicUtil now and it still works.

@Jowan-Spooner
Copy link
Collaborator

There is now an error, because initialized is using two different spellings!

@Jowan-Spooner
Copy link
Collaborator

Looks good to me. Thanks!

@Jowan-Spooner Jowan-Spooner merged commit 1e2b089 into dialogic-godot:main Mar 27, 2024
2 checks passed
@CakeVR CakeVR deleted the remember-timeline-sidebar-size branch March 27, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember the Timeline Right Sidebar Size
2 participants