SDL1: Fix windowed video mode with sdl12-compat #7148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 24.04 when running in a window, `SDL_GetVideoInfo` returns the display size rather than the window size, resulting in incorrect scaling. Using `SDL_GetVideoSurface` instead of `SDL_GetVideoInfo` fixes this.
AJenbo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04, which uses sdl12-compat, when running in a window,
SDL_GetVideoInforeturns the display size rather than the window size, resulting in incorrect scaling.Using
SDL_GetVideoSurfaceinstead ofSDL_GetVideoInfofixes this.