-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make filter-abund use the C++ threading code #76
Comments
Is filter-abund objectively or subjectively slower than it used to be?
|
On Fri, Jul 05, 2013 at 09:50:18PM -0700, mr-c wrote:
Same speed. Other things have sped up. Plus, it's using a Python-based --titusC. Titus Brown, ctb@msu.edu |
Check out https://github.com/ctb/khmer/tree/be_threadwrite, especially line 59 onwards of filter-abund -- https://github.com/ctb/khmer/blob/be_threadwrite/scripts/filter-abund.py#L59 Comments? |
Also see: https://github.com/ctb/khmer/blob/be_threadwrite/scripts/normalize-by-median.py#L100 Not 100% working yet, but I think an unambiguous win in most ways. |
See #92 |
See #1469, which simplifies the code instead :) |
filter-abund seems really slow now! this would be good practice for making normalize-by-median use the new thread stuff.
The text was updated successfully, but these errors were encountered: