[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make filter-abund use the C++ threading code #76

Closed
ctb opened this issue Jul 6, 2013 · 6 comments
Closed

make filter-abund use the C++ threading code #76

ctb opened this issue Jul 6, 2013 · 6 comments
Assignees
Milestone

Comments

@ctb
Copy link
Member
ctb commented Jul 6, 2013

filter-abund seems really slow now! this would be good practice for making normalize-by-median use the new thread stuff.

@ghost ghost assigned mr-c Jul 6, 2013
@mr-c
Copy link
Contributor
mr-c commented Jul 6, 2013

Is filter-abund objectively or subjectively slower than it used to be?
On Jul 5, 2013 11:55 PM, "C. Titus Brown" notifications@github.com wrote:

filter-abund seems really slow now! this would be good practice for making
normalize-by-median use the new thread stuff.


Reply to this email directly or view it on GitHubhttps://github.com//issues/76
.

@ctb
Copy link
Member Author
ctb commented Jul 6, 2013

On Fri, Jul 05, 2013 at 09:50:18PM -0700, mr-c wrote:

Is filter-abund objectively or subjectively slower than it used to be?

Same speed. Other things have sped up. Plus, it's using a Python-based
threading system, which I don't think is very efficient.

--titus

C. Titus Brown, ctb@msu.edu

@ghost ghost assigned camillescott Jul 26, 2013
@ctb
Copy link
Member Author
ctb commented Jul 26, 2013

Check out https://github.com/ctb/khmer/tree/be_threadwrite, especially line 59 onwards of filter-abund --

https://github.com/ctb/khmer/blob/be_threadwrite/scripts/filter-abund.py#L59

Comments?

@ctb
Copy link
Member Author
ctb commented Jul 26, 2013

Also see:

https://github.com/ctb/khmer/blob/be_threadwrite/scripts/normalize-by-median.py#L100

Not 100% working yet, but I think an unambiguous win in most ways.

@ctb
Copy link
Member Author
ctb commented Aug 21, 2013

See #92

@ctb
Copy link
Member Author
ctb commented Oct 4, 2016

See #1469, which simplifies the code instead :)

@ctb ctb closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants