Mandatory fields for logs and position #12

dignajar · 2020-12-11T10:59:33Z

Example for TEXT format.

2020-12-11 11:55:55 - INFO - Cache - 127.0.0.1 - None - User not found in the cache. - xxxxx
2020-12-11 11:55:55 - INFO - Aldap - 127.0.0.1 - None - Authenticating user. - xxxxx - xxxxx@xxx.com
2020-12-11 11:55:55 - INFO - Aldap - 127.0.0.1 - None - There was an error trying to bind.

Example for JSON format.

{"date": "2020-12-11 11:58:49", "level": "INFO", "objectName": "Cache", "ip": "127.0.0.1", "referrer": null, "message": "User not found in the cache.", "username": "xxxxx"}
{"date": "2020-12-11 11:58:49", "level": "INFO", "objectName": "Aldap", "ip": "127.0.0.1", "referrer": null, "message": "Authenticating user.", "username": "xxxxx", "finalUsername": "xxxxx@xxxxx.com"}
{"date": "2020-12-11 11:58:49", "level": "INFO", "objectName": "Aldap", "ip": "127.0.0.1", "referrer": null, "message": "There was an error trying to bind."}

marianobilli · 2020-12-11T11:04:31Z

files/logs.py

 		except Exception as e:
 			pass

+		# Merge dictionaries
+		mandatoryFields.update(fields)


I would do something like
allFields = mandatoryFields.update(fields)

otherwise when you keep reading the code bellow it seems you only print the mandatoryFields, you have to read above to realize that at that point mandatoryFields contains all the fields

marianobilli · 2020-12-11T11:06:35Z

files/logs.py

 		if self.format == 'JSON':
-			print(json.dumps(fields))
+			print(json.dumps(mandatoryFields))


then here you do
print(json.dumps(allFields))

marianobilli · 2020-12-11T11:06:57Z

files/logs.py

 		else:
-			print(" - ".join(fields.values()))
+			print(' - '.join(map(str, mandatoryFields.values())))


print(' - '.join(map(str, allFields.values())))

Mandatory fields for logs and position

1b387e1

dignajar requested a review from marianobilli December 11, 2020 10:59

marianobilli reviewed Dec 11, 2020

View reviewed changes

Improve variable names

293f8c1

marianobilli approved these changes Dec 11, 2020

View reviewed changes

dignajar merged commit c3b3313 into master Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mandatory fields for logs and position #12

Mandatory fields for logs and position #12

Mandatory fields for logs and position #12

Mandatory fields for logs and position #12

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment