fix: don't accept extra fields inside the currency options on create (#…

…673)
dinerojs · Nov 19, 2022 · 9e72f9e · 9e72f9e · vercel · Nov 19, 2022
1 parent 6c0e98b
commit 9e72f9e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/core/src/helpers/createDinero.ts b/packages/core/src/helpers/createDinero.ts
@@ -12,9 +12,11 @@ export function createDinero<TAmount>({
 }: CreateDineroOptions<TAmount>) {
   return function dinero({
     amount,
-    currency,
-    scale = currency.exponent,
+    currency: { code, base, exponent },
+    scale = exponent,
   }: DineroOptions<TAmount>): Dinero<TAmount> {
+    const currency = { code, base, exponent };
+
     onCreate?.({ amount, currency, scale });
 
     return {

diff --git a/packages/dinero.js/src/__tests__/dinero.test.ts b/packages/dinero.js/src/__tests__/dinero.test.ts
@@ -17,4 +17,20 @@ describe('dinero', () => {
 
     expect(snapshot).toMatchObject({ amount: 500, currency: USD, scale: 2 });
   });
+  it('cleans up unwanted properties from the options', () => {
+    const d = dinero({
+      amount: 500,
+      // @ts-expect-error
+      currency: { code: 'USD', exponent: 2, base: 10, _extraProperty: 123 },
+      _extraProperty: 123,
+    });
+
+    const snapshot = toSnapshot(d);
+
+    expect(snapshot).toStrictEqual({
+      amount: 500,
+      currency: USD,
+      scale: 2,
+    });
+  });
 });