[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getrelease.sh fails if extra fields are in sources.list #1880

Closed
swarren opened this issue Jun 19, 2015 · 2 comments
Closed

getrelease.sh fails if extra fields are in sources.list #1880

swarren opened this issue Jun 19, 2015 · 2 comments
Labels
bug

Comments

@swarren
Copy link
swarren commented Jun 19, 2015

installer/ubuntu/getrelease.sh prints $3 of the matching line in /etc/apt/sources.list. However, this isn't always the release name. For example, consider the following entry:

deb [arch=armhf] http://ports.ubuntu.com/ubuntu-ports/ trusty main restricted universe multiverse

$4 is required not $3.

(Serves me right for hacking the file in an attempt to run x86 binaries under qemu I suppose...)
@dnschneid dnschneid added the bug label Jun 23, 2015
@dnschneid
Copy link
Owner

Yeah, that's true. From the man page it looks like we need to use the field following the URI (wherever it is).

tonyxue added a commit to tonyxue/cruise that referenced this issue Jun 28, 2015
@tonyxue
Lookup release name correctly. Fixes dnschneid#1880.
062933b 
getrelease.sh now looks up release name after the URI of one of the type
specified in the man page.
@tonyxue tonyxue mentioned this issue Jun 28, 2015
Merged
@tonyxue
Copy link
Contributor
tonyxue commented Jun 28, 2015

Fix is in PR #1903

BooDoo pushed a commit to BooDoo/chroagh that referenced this issue Aug 23, 2015
@tonyxue @BooDoo
Lookup release name correctly. Fixes dnschneid#1880.
44cdd2a 
getrelease.sh now looks up release name after the URI of one of the type
specified in the man page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swarren @dnschneid @tonyxue