Remove gksu from gtk-extra target for debian buster and kali-rolling #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But hey, they've got gdebi working on policykit. :) Per debian's bug: https://bugs.debian.org/867236
dnschneid
reviewed
Feb 16, 2018
targets/gtk-extra
Outdated
| . "${TARGETSDIR:="$PWD"}/common" | ||
|
|
||
| ### Append to prepare.sh: | ||
| install_dummy network-manager network-manager-gnome | ||
| install gdebi gksu | ||
| install gdebi | ||
| if release -lt buster -lt kali-rolling; then |
There was a problem hiding this comment.
This whitelist results in nothing on Ubuntu. So you probably want to add -lt artful
There was a problem hiding this comment.
Done!
Hmm. I imagine it still worked when I tested Xenial because gdebi requires gksu before debian ported it to policy kit. Would simply removing it from all targets be a better approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per debian's bug, they've removed gksu (but patched gdebi to use policy kit):
https://bugs.debian.org/867236
Should fix 3623/3621 and buster, which has the same issue atm.