Avoid letting crouton run inside crostini #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 ( not that it matters of course ) |
|
LGTM |
| if ! awk -F= '/_RELEASE_BUILD_NUMBER=/ { exit int($2) < '"${CROS_MIN_VERS:-0}"' }' \ | ||
| if [ -n "$DOWNLOADONLY" ]; then | ||
| : | ||
| elif ! grep -q '_RELEASE_BUILD_NUMBER=' /etc/lsb-release 2>/dev/null; then |
There was a problem hiding this comment.
Just curious, is this enough or should it be even more qualified with 'CHROMEOS_RELEASE_BUILD_NUMBER' here and on line 145?
There was a problem hiding this comment.
I think that would mess up Chromium OS
There was a problem hiding this comment.
Well, I thought so too at first but after checking it seems all the Chromium OS derivatives use the 'CHROMEOS_' prefix. Here's the lsb-release files for CrOS, Chromium OS, Cloudready, & Flint OS (yes, I have all of them)
lsb-release.all.txt(expired)- lsb-release.all.txt
But I guess things can change so whatever you decide is fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: please also comment on the README and error message wording.