[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale for Ubuntu Xenial #3952

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Conversation

kindrowboat
Copy link
Contributor

Previously, core checked for the absence of /etc/default/locale to
determine if a locale needed to be generated an set as the default.
Unfortunately, in Xenial /etc/default/locale exists by default in
a clean installation with a comment that reads:

# File generated by update-locale

This commit enhances the test for /etc/default/locale to check that
the file contains LANG=, ensuring that a default locale is set.

Fixes: #2921 and #3283

Previously, core checked for the absence of /etc/default/locale to
determine if a locale needed to be generated an set as the default.
Unfortunately, in Xenial /etc/default/locale exists by default in
a clean installation with a comment that reads:

    # File generated by update-locale

This commit enhances the test for /etc/default/locale to check that
the file contains `LANG=`, ensuring that a default locale is set.

Fixes: dnschneid#2921 and dnschneid#3283
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kindrowboat
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

targets/core Outdated Show resolved Hide resolved
This commit ensures that when checking if `LANG=` is set in
`/etc/default/locale` that:

1. stdout and stderr are silenced, and
2. `LANG=` is not commented out (something that could reasonably
   happen in future releases for documentation)

Thank you @dnschneid for the suggestions.
@kindrowboat
Copy link
Contributor Author

Thank you for the suggestion. I put it in and tested it out, and it works great.

@kindrowboat
Copy link
Contributor Author

@dnschneid do you need me to do anything else to make this merge ready?

@ndarilek
Copy link

Would love to see this merged. I'm having to manually perform these steps in my chroots and it's a bit of a pain.

Thanks!

@ndarilek
Copy link

FWIW, under Bionic at least I had to also run apt-get install -y language-pack-en before this worked. Not sure if that's also true under latest Xenial, but with that addition, I'd call this ready to merge, and probably essential since I couldn't get anything significant running under GNOME without it.

@dnschneid dnschneid merged commit ed607dd into dnschneid:master Jan 17, 2019
@dnschneid
Copy link
Owner

@ndarilek give it a shot and if the latest crouton still needs language-pack-en, open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants