Allow CRAS to compile by excluding some warnings from being treated as errors #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for fixing this! |
|
🤦♂️ and this fails on focal because -Wstringop-overread didn't exist in that GCC version. I'll send a pull request in a bit to change it to just -Wno-error, once I've tested it on sid/focal/kali-rolling. |
This was referenced Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRAS code triggers
attributes,maybe-uninitialized, andstringop-overreadwarnings, and Crouton compiles it with-Werror, which turns all warnings into errors. This excludes those specific warnings from becoming errors, and allows CRAS to compile (under sid, at least).Fixes #4618.