[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into live #43315

Merged
merged 20 commits into from
Nov 5, 2024
Merged

Merge main into live #43315

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
33cd37b
[Diagnostics] Add EventSource Callback Possible Deadlock Warning
mdh1418 Oct 24, 2024
8c7eb9c
Move warning to more relevant doc
mdh1418 Oct 25, 2024
b2aa5b2
Elaborate on avoiding complex operations
mdh1418 Oct 25, 2024
59fb983
Expand list of common pitfalls
mdh1418 Oct 25, 2024
3279637
Update rationale for pitfalls
mdh1418 Oct 25, 2024
64ac663
Add re-entrancy guard tip
mdh1418 Oct 25, 2024
96fad7b
Clarify precaution
mdh1418 Oct 29, 2024
20c29b7
What's new in F# 9
0101 Oct 30, 2024
abf85dd
change blog-style code blocks to regular
0101 Oct 30, 2024
0c1ede7
Apply suggestions from code review
0101 Oct 31, 2024
d329193
Fixed formatting, made language changes H2
0101 Oct 31, 2024
4c5db39
update
0101 Oct 31, 2024
53f7ef1
update
0101 Oct 31, 2024
dee1058
update
0101 Oct 31, 2024
9ecbe97
markdown lint
0101 Nov 1, 2024
3a65014
Apply suggestions from code review
0101 Nov 4, 2024
e26076e
suggestions from review
0101 Nov 4, 2024
8366cfa
Random improvements to config articles (#43273)
gewarren Nov 4, 2024
2fbaea2
Merge pull request #43197 from mdh1418/add_deadlock_warning_for_event…
mdh1418 Nov 4, 2024
30839a4
Merge pull request #43260 from 0101/whats-new-in-fsharp-9
0101 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand list of common pitfalls
  • Loading branch information
@mdh1418
mdh1418 committed Oct 25, 2024
commit 59fb983a47e37893ca6b6f639d189f2949769fe6
2 changes: 1 addition & 1 deletion docs/core/diagnostics/eventsource-collect-and-view-traces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ this isn't required. Following is an example `EventListener` implementation that
```

> [!WARNING]
> Potential Deadlocks with EventSource Callbacks
> Potential Pitfalls when implementing EventSource Callbacks via EventListener include deadlocks, infinite recursions, and uninitialized types.
>
> When implementing EventSources, be cautious with invoking lock-acquiring APIs within EventSource callbacks. EventSource instances are initialized early in the runtime, before some core features are fully initialized. As a result, the re-entrant behavior of EventSource callbacks may cause deadlocks if the callback attempts to acquire locks already held by the thread that triggered the callback.
>
Expand Down