[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix findDOMNode deprecation issue under React 18.3.1 #2403

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix: fix findDOMNode deprecation issue under React 18.3.1 #2403

merged 1 commit into from
Jun 3, 2024

Conversation

jikkai
Copy link
Member
@jikkai jikkai commented Jun 3, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 3, 2024
@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jun 3, 2024
@codecov Codecov
Copy link
codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 27.13%. Comparing base (c5ae960) to head (647b9a2).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/ui/src/views/components/doc-bars/hook.ts 0.00% 3 Missing ⚠️
...ormatting-ui/src/components/color-picker/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2403   +/-   ##
=======================================
  Coverage   27.12%   27.13%           
=======================================
  Files        1646     1646           
  Lines       83047    83047           
  Branches    17203    17205    +2     
=======================================
+ Hits        22525    22532    +7     
+ Misses      60522    60515    -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 3, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai merged commit 41d21c3 into dev Jun 3, 2024
9 checks passed
@jikkai jikkai deleted the fix/react-18.3.1 branch June 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jikkai