[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hodor plugin - Use IP bytes for user IP identification #1606

Merged
merged 4 commits into from
May 19, 2023
Merged

Hodor plugin - Use IP bytes for user IP identification #1606

merged 4 commits into from
May 19, 2023

Conversation

Mis1eader-dev
Copy link
Member

This will help reduce memory usage, and unnecessary operations on redundant characters. Accounting for both ipv4 and ipv6.

@Mis1eader-dev
Copy link
Member Author

I suggest adding a method in trantor::InetAddress to be called toIpNetEndian, that doesn't create a pretty-printable string. It just puts the bytes in the string.
Since the Windows MSVC version failed to compile, I will make a pull request on trantor for this function to be added, and reference it here in Hodor.

@Mis1eader-dev
Copy link
Member Author

Waiting for the trantor pull request to be merged and for drogon to reference the tag of that commit onward. Then I'll use these new methods within Hodor and make a new commit here.

@Mis1eader-dev Mis1eader-dev mentioned this pull request May 19, 2023
Merged
@an-tao an-tao merged commit 7fce0f1 into drogonframework:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mis1eader-dev @an-tao