[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7620: EOFCREATE and RETURNCONTRACT container validation tests #640

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

πŸ—’οΈ Description

Adds container validation tests for cases when the EOFCREATE and RETURNCONTRACT opcodes are misused.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the scope:tests Scope: Test cases label Jun 20, 2024
@marioevz marioevz requested a review from shemnon June 20, 2024 20:59
@marioevz marioevz force-pushed the eofcreate-container-validation-cases branch from a3058fc to a7d8f3d Compare June 20, 2024 21:03
@marioevz marioevz force-pushed the eofcreate-container-validation-cases branch from a7d8f3d to ffa3b57 Compare June 20, 2024 21:57
@marioevz
Copy link
Member Author

@shemnon @chfast currently the following code validation test cases are failing with evmone:

The test cases seem to be following the spec but let me know if I could be missing something.

@shemnon
Copy link
Collaborator
shemnon commented Jun 20, 2024

Spec was updated. If we had versioning turned on we could have added a version bump to that update and tooling could have caught it.

ethereum/EIPs#8586

@chfast
Copy link
Collaborator
chfast commented Jun 21, 2024

@marioevz, this change is not in evmone's master yet. There are still 3 changes in the review process on our side: https://github.com/ethereum/evmone/pulls?q=is%3Apr+is%3Aopen+label%3AEOF.

@chfast
Copy link
Collaborator
chfast commented Jun 25, 2024

@marioevz this change has landed in evmone master.

ExceptionMessage(
EOFException.TOPLEVEL_CONTAINER_TRUNCATED, "err: toplevel_container_truncated"
),
ExceptionMessage(EOFException.INVALID_MAX_STACK_HEIGHT),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what this maps to? "eofexception.invalid_max_stack_height"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants