Fix broken tests

eukaryo · Nov 16, 2023 · 77d9fff · 77d9fff
1 parent aa49090
commit 77d9fff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 45 deletions.
diff --git a/optuna_dashboard/ts/components/DataGrid.tsx b/optuna_dashboard/ts/components/DataGrid.tsx
@@ -262,7 +262,7 @@ function DataGridHeaderColumn<T>(props: {
                 setFilterMenuAnchorEl(null)
               }}
             >
-              {filterChoices.map((choice, i) => (
+              {filterChoices.map((choice) => (
                 <MenuItem
                   key={choice}
                   onClick={() => {

diff --git a/typescript_tests/DataGrid.test.tsx b/typescript_tests/DataGrid.test.tsx
@@ -1,14 +1,15 @@
 import React from "react"
 global.URL.createObjectURL = jest.fn()
 
-import { cleanup, render, fireEvent } from "@testing-library/react"
+import { cleanup, render } from "@testing-library/react"
 import {
   DataGrid,
   DataGridColumn,
 } from "../optuna_dashboard/ts/components/DataGrid"
 
 afterEach(cleanup)
 
+// TODO(c-bata): Add tests to check filterChoices option
 it("Filter rows of DataGrid", () => {
   interface DummyAttribute {
     id: number
@@ -23,7 +24,7 @@ it("Filter rows of DataGrid", () => {
     { id: 5, key: "foo", value: 3 },
   ]
   const columns: DataGridColumn<DummyAttribute>[] = [
-    { field: "key", label: "Key", filterable: true },
+    { field: "key", label: "Key" },
     {
       field: "value",
       label: "Value",
@@ -39,46 +40,4 @@ it("Filter rows of DataGrid", () => {
     />
   )
   expect(queryAllByText("bar").length).toBe(2)
-
-  // Filter rows by "foo"
-  fireEvent.click(queryAllByText("foo")[0])
-  expect(queryAllByText("foo").length).toBe(3)
-  expect(queryAllByText("bar").length).toBe(0)
-})
-
-it("Filter rows after sorted", () => {
-  interface DummyAttribute {
-    id: number
-    key: string
-    value: number
-  }
-  const dummyAttributes = [
-    { id: 1, key: "foo", value: 4000 },
-    { id: 2, key: "bar", value: 1000 },
-    { id: 3, key: "bar", value: 2000 },
-    { id: 4, key: "foo", value: 3000 },
-    { id: 5, key: "foo", value: 5000 },
-  ]
-  const columns: DataGridColumn<DummyAttribute>[] = [
-    { field: "key", label: "Key", filterable: true },
-    {
-      field: "value",
-      label: "Value",
-      sortable: true,
-    },
-  ]
-
-  const { getByText, queryAllByText } = render(
-    <DataGrid<DummyAttribute>
-      columns={columns}
-      rows={dummyAttributes}
-      keyField={"id"}
-    />
-  )
-  // Sort and filter rows
-  fireEvent.click(getByText("Value"))
-  fireEvent.click(queryAllByText("bar")[0])
-
-  expect(queryAllByText("1000").length).toBe(1)
-  expect(queryAllByText("2000").length).toBe(1)
 })