[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cn doc #834

Merged
merged 1 commit into from
Jun 6, 2019
Merged

add cn doc #834

merged 1 commit into from
Jun 6, 2019

Conversation

loverto
Copy link
Contributor
@loverto loverto commented May 25, 2019

No description provided.

@guyonroche
Copy link
Collaborator

@loverto This looks cool.
How is this file generated?
The readme file does change now and then - new features, version history, etc. so it's likely that this translation will get out of date. Would it be worth adding a "Correct as of v1.12.0" stamp at the top?
Also - if we can't update it on every release, it might be worth removing the "New Features" section

@loverto
Copy link
Contributor Author
loverto commented Jun 5, 2019

This file is translated by me. I can keep this file during the update. Of course, you add the version. I will add it later.

@guyonroche guyonroche merged commit e5bafd8 into exceljs:master Jun 6, 2019
@jixunmoe
Copy link
jixunmoe commented Feb 3, 2020

This file is translated by me. I can keep this file during the update. Of course, you add the version. I will add it later.

I don't believe you translated this document yourself, the use of machine translation is quite obvious.


即使只有失败测试的公关也很好

PR (Pull Request) ≠ 公关 (Public Relations)


冰冻视图

This one is actually OK, but there's a word for this in Chinese. Please consult the official documentation for terminologies.

冻结窗格


要冻结的列数。要仅冻结行,请将其设置为 0 或未定义

“未定义” 应该是保留字 undefined,不用翻译

"未定义" should be the reserved identifier undefined and not be translated.


Promises returned from functions switched from Bluebird to native node Promise which can break calling code if they rely on Bluebird's extra features.

从 Bluebird 切换到本机节点 Promise 的函数返回 Promise,如果它们依赖 Bluebird 的额外功能,它可以破坏调用代码。

A better example would be:

函数返回的 Promise 对象由 Bluebird 实现更换为原生 Promise 实现。如果调用方依赖 Bluebird 的某些特性则可能会出错。


首先,通过 addImage()函数将图像添加到工作簿,该函数也将返回 imageId 值。
...
请注意,用于此的坐标系统为零,因此 A1 的左上角将为 {col:0,row:0}。 可以通过使用浮点数来指定单元的分数,例如, A1 的中点是 {col:0.5,row:0.5}。
...
CSV 解析器使用 [fast-csv](https://www.npmjs.com/package/fast-csv)编写 CSV 文件。

很明显的代码片段中滥用全角符号,连 Markdown 里的链接括号都被你转换了。

The use of full-width characters. Quite common when you throw the whole paragraph (if not the whole document) to the translator.


My suggestions:

  • Label the link to Chinese documentation with "Help needed to improve the translation quality" or similar text.
  • Get someone to actually proofread the document instead of blindly merging it.
  • Use inline-monospace tag in the English document for keywords e.g. undefined and 0 (values can be copied to use).

@wang1212
Copy link
Contributor

I think the translation is pretty bad!!! Of course, I hope I can take the time to improve it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants