[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PhenoGrid visualisation features #86

Open
damiansm opened this issue Nov 9, 2015 · 2 comments
Open

New PhenoGrid visualisation features #86

damiansm opened this issue Nov 9, 2015 · 2 comments

Comments

@damiansm
Copy link
Contributor
damiansm commented Nov 9, 2015

Not really a task yet but following discussion was had with Harry Nov 2015:

Jules is going to start looking into the REST stuff as his next big task which should make things easier. We did do that work for AMIA to export Exomiser results in a suitable format for PhenoGrid so sure some of that could be reused.

One thing I would like to see is if I can reuse PhenoGrid for is to show phenotype match results for just a single disease/patient vs a single gene in the IMPC portal and possibly Exomiser individual results. So for IMPC instead of different genes from different species on the horizontal axis I would have different models from mouse for the same gene. For Exomiser, upon clicking on something to dynamically load for each gene result, we would show a PhenoGrid with human, mouse and fish results on the horizontal axis. I am figuring that current PhenoGrid should be capable of taking a bunch of any objects associated with phenotype terms for the horizontal axis and it should not matter if they are genes from diff species, diff models for the same gene etc?

I do get the political aspect of combining our tools though so we can try and do the simpler experiment of course of just showing PhenoGrid for the top 50 Exomiser ranked candidates. I was also wondering if we should try and do all this integration in the context of Tudor's Patient Archive. Are we planning to have a PA installation on the Monarch site eventually anyway. Tudor has already done a nice job of pulling in Exomiser so wondering if we should not kill 2 birds with one stone and see if we can plug PhenoGrid in there?

@julesjacobsen
Copy link
Contributor
julesjacobsen commented Jul 28, 2016

Now that Phenogrid has been heavily refactored for more generic usage this is doable.

  • Re-write PhenoGridAdaptor to write out the new phenogrid input format - see IMPC implementation for details.
  • Remove phenogrid specific code from Organism
  • Remove phenogrid specific Json annotations from PhenotypeTerm and PhenotypeMatch
  • Look into refactoring PhenotypeTerm to follow same model as PFX OntologyClass.of(id, label) pattern, moving the IC into the PhenotypeMatch. This isn't strictly the correct place for it (it's a function of the LCS), but makes for cleaner coding. Given these are constants the builder should probably be backed by a cache to prevent multiple instances of the same thing.

@julesjacobsen
Copy link
Contributor

linked to #101

julesjacobsen pushed a commit that referenced this issue Jul 29, 2016
…This is only a partial implementation pending changes required for #86
@damiansm damiansm added this to Viz in Issues triage Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues triage
User improvements inc viz
Development

No branches or pull requests

2 participants