[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_matching_ents #10451

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix get_matching_ents #10451

merged 2 commits into from
Mar 7, 2022

Conversation

polm
Copy link
Contributor
@polm polm commented Mar 7, 2022

Description

Example.get_matching_ents was added as part of #9669, but for some reason master seems to have an old version of the code that just doesn't work. It's already covered by tests that were in #9669 (and fail without this commit) but were succeeding there for some reason.

Types of change

Fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@polm
Fix get_matching_ents
c1995d7 
Not sure what happened here - the code prior to this commit simply does
not work. It's already covered by entity linker tests, which were
succeeding in the NEL PR, but couldn't possibly succeed on master.
@polm polm added bug Bugs and behaviour differing from documentation feat / nel Feature: Named Entity linking feat / training Feature: Training utils, Example, Corpus and converters labels Mar 7, 2022
svlandeg
svlandeg approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in as soon as it goes green!

@polm
Fix test
3d7d828 
Test was indented inside another test and so doesn't seem to have been
running properly.
@svlandeg svlandeg merged commit 61ba545 into explosion:master Mar 7, 2022
mrriteshranjan added a commit to mrriteshranjan/spaCy that referenced this pull request Mar 11, 2022
@mrriteshranjan
Revert "Fix get_matching_ents (explosion#10451)"
183d0bb 
This reverts commit 61ba545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / nel Feature: Named Entity linking feat / training Feature: Training utils, Example, Corpus and converters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polm @svlandeg