[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues for Mypy 0.950 and Pydantic 1.9.0 #10786

Merged
merged 13 commits into from
May 25, 2022
Merged

Fix issues for Mypy 0.950 and Pydantic 1.9.0 #10786

merged 13 commits into from
May 25, 2022

Conversation

richardpaulhudson
Copy link
Contributor
@richardpaulhudson richardpaulhudson commented May 12, 2022 •
edited
Loading

This spaCy PR depends on explosion/thinc#599, so that this spaCy PR will not turn green until a version of Thinc is released that incorporates that Thinc PR.

Types of change

Mypy / Pydantic fixes

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

adrianeboyd
adrianeboyd reviewed May 13, 2022
View reviewed changes
spacy/util.py Outdated Show resolved Hide resolved
@abi-jey
Copy link
abi-jey commented May 16, 2022

Do you think this, will be available in the next release?

@svlandeg svlandeg added enhancement Feature requests and improvements types Issues related to typing or typing tools labels May 17, 2022
@svlandeg
Copy link
Member

Do you think this, will be available in the next release?

Hi! We're planning to finish & release this for Thinc 8.1 and spaCy 3.4 🎉

svlandeg
svlandeg reviewed May 17, 2022
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's encouraging to see that we can remove so many ignores & casts, nice work Richard!

spacy/errors.py Outdated Show resolved Hide resolved
spacy/util.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
danieldk
danieldk reviewed May 23, 2022
View reviewed changes
Copy link
Collaborator
@danieldk danieldk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really nice improvement! I added a question about casting in some set_dim calls.

@richardpaulhudson richardpaulhudson marked this pull request as ready for review May 23, 2022 08:56
@danieldk danieldk self-requested a review May 23, 2022 09:16
@svlandeg svlandeg self-requested a review May 23, 2022 09:23
@svlandeg svlandeg added the v3.4 Related to v3.4 label May 24, 2022
svlandeg
svlandeg reviewed May 24, 2022
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Richard - nice work!

spacy/util.py Outdated Show resolved Hide resolved
@svlandeg svlandeg merged commit 32954c3 into explosion:master May 25, 2022
@adrianeboyd adrianeboyd mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

@svlandeg svlandeg svlandeg left review comments

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests and improvements types Issues related to typing or typing tools v3.4 Related to v3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richardpaulhudson @abi-jey @svlandeg @danieldk @adrianeboyd