[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend to pydantic v1.10 #11635

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Extend to pydantic v1.10 #11635

merged 1 commit into from
Oct 14, 2022

Conversation

adrianeboyd
Copy link
Contributor

Description

  • Update types to allow field defaults in schemas for updated pydantic+mypy

Types of change

Mostly a chore.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Extend to pydantic v1.10
10481f7 
* Update types in `spacy.schemas` for updated pydantic+mypy
@adrianeboyd adrianeboyd added the types Issues related to typing or typing tools label Oct 12, 2022
@adrianeboyd adrianeboyd reopened this Oct 12, 2022
@adrianeboyd adrianeboyd merged commit 6b5a3e7 into explosion:master Oct 14, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees
No one assigned
Labels
types Issues related to typing or typing tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @rmitsch