[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from distutils to setuptools/sysconfig #12853

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Switch from distutils to setuptools/sysconfig #12853

merged 1 commit into from
Jul 24, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Additionally remove outdated is_new_osx check and settings.

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Switch from distutils to setuptools/sysconfig
54046ec 
Additionally remove outdated `is_new_osx` check and settings.
svlandeg
svlandeg approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of all of these!

@svlandeg svlandeg merged commit f8f489b into explosion:master Jul 24, 2023
14 checks passed
@adrianeboyd
Copy link
Contributor Author
adrianeboyd commented Jul 24, 2023 •
edited
Loading

For the is_new_osx thing, there is a slight possibility that someone might complain that it breaks something, but we don't have any good way to test it at this point. We could consider adding it back in (also for a new other packages, but with the platform.mac_ver() check from spacy instead of distutils.util.get_platform() that's in a few other places).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @svlandeg