[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Load the cli module lazily for spacy.info (#12962)" #13040

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Revert "Load the cli module lazily for spacy.info (#12962)" #13040

merged 1 commit into from
Oct 4, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

This reverts commit beda27a.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface labels Oct 4, 2023
@adrianeboyd adrianeboyd linked an issue Oct 4, 2023 that may be closed by this pull request
spacy.cli.download is no longer available #13039
Closed
@adrianeboyd adrianeboyd marked this pull request as draft October 4, 2023 11:15
@adrianeboyd
Copy link
Contributor Author

I am not 100% sure that this is the source of the difference.

@adrianeboyd
Copy link
Contributor Author

It does look like this is the source of the problem (ugh).

@adrianeboyd adrianeboyd marked this pull request as ready for review October 4, 2023 14:30
@adrianeboyd
Copy link
Contributor Author

I ... have no idea how to write a test for this, so let's move forward just with the revert.

@adrianeboyd adrianeboyd merged commit aec59c0 into explosion:master Oct 4, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spacy.cli.download is no longer available
1 participant
@adrianeboyd