[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1155 Support node version 16.x in elyra-canvas #1156

Merged
merged 3 commits into from
Aug 16, 2022
Merged

#1155 Support node version 16.x in elyra-canvas #1156

merged 3 commits into from
Aug 16, 2022

Conversation

nmgokhale
Copy link
Member

Fixes #1155 and #1132

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@nmgokhale nmgokhale self-assigned this Aug 12, 2022
matthoward366
matthoward366 requested changes Aug 15, 2022
View reviewed changes
Copy link
Member
@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the 2 build files from 14.x to 16.x under https://github.com/elyra-ai/canvas/tree/main/.github/workflows.
There was also a change in npm 8 where in the publish cmd you'll need to reference the config file.

npm publish --userconfig=~/.npmrc

matthoward366
matthoward366 previously approved these changes Aug 15, 2022
View reviewed changes
@nmgokhale
Copy link
Member Author

@matthoward366 Following step failed -

curl -L http://localhost:3001/coverage/download -o coverage.zip
unzip coverage.zip

Producing broken (bad CRC) zip archives on Node v15.6.0 is a known issue fixed in crc32-stream.

crc32-stream version needs to be updated under istanbul-middleware. There's a PR open for this but this package isn't updated in last 7 years. We may have to replace this package in test harness.

canvas-demo@0.0.1 /Users/neha.gokhale/Documents/GitHub/canvas/canvas_modules/harness
└─┬ istanbul-middleware@0.2.2
  └─┬ archiver@0.14.4
    └─┬ zip-stream@0.5.2
      └─┬ compress-commons@0.2.9
        └── crc32-stream@0.3.4

@matthoward366
Copy link
Member

@nmgokhale You can remove the code for this since it's not actually used anymore and doesn't work for Cypress.

matthoward366
matthoward366 reviewed Aug 16, 2022
View reviewed changes
scripts/publish_modules.sh
echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}" > .npmrc
npm publish
echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}" > ~/.npmrc
npm publish --userconfig=~/.npmrc
Copy link
Member
@matthoward366 matthoward366 Aug 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure but I think we also need --registry here. This is what I ran into with another repo.

@matthoward366 matthoward366 merged commit afb4e35 into elyra-ai:main Aug 16, 2022
@nmgokhale nmgokhale deleted the node-16-test-harness branch August 16, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthoward366 matthoward366 matthoward366 approved these changes

Assignees

@nmgokhale nmgokhale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support node 16.x in elyra-canvas
2 participants
@nmgokhale @matthoward366