Improving Jeelink and RFM2Pi compatability #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested the auto baud selection, firmware version reporting and device settings confirmation with a JeeLink v3 (rf69cw) on both windows and linux, I found the serial responses were not consistent causing errors this was eliminated by increasing the wait times to 2 secs. The "Jeelink" devices seem to function identically to "rfm2pi". (tested using RF12demo.12 only)
Some devices may use the leading "OK" without RSSI eg rfm12 jeelink running stock firmware.
The older rfm2pi boards which do not have the "v" command had an issue with the absent self.info[1] field when confirming if the configuration string was available.
pb66
added a commit
that referenced
this pull request
Sep 6, 2014
Improving Jeelink and RFM2Pi compatability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure why, but the Jeelink v3 rfm69 device needs a longer wait time for a serial response. It 's highly likely that the serial code is needs "optimising".
Auto baud setting, firmware version logging and configuration confirmations now tested on
RFM2Pi v2 rfm12 running older RF12demo firmware (pre-"v" version)
RFM2Pi v2 rfm69 running RF12demo.12
JeeLink v3 rfm69 both "rfm2pi" and "original" versions of RF12demo.12 tested ok