Optimize glMapBufferRange() to not generate temporary JS garbage #19592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bb9d7d
to
718f81e
Compare
sbc100
reviewed
Jun 12, 2023
| access: access, | ||
| }; | ||
| if (!GL.mappedBuffers[binding]) GL.mappedBuffers[binding] = {}; | ||
| binding = GL.mappedBuffers[binding]; |
There was a problem hiding this comment.
Would it be shorter to write Object.assign(GL.mappedBuffers[binding], {offset, length, mem, access})?
There was a problem hiding this comment.
It would be shorter, but I think that would generate garbage (since that would assign over the previous {} part). Closure can minify the key names here though.
There are two reasons why I am not considering this code location for strict tight code size savings:
- This is in an emulation path. Users who utilize strict web code size are likely to also utilize (only) native web features, so this type of OpenGL ES 3 emulation (the FULL_ES3 feature) would not be in that carefully crafted path, and
- To optimize these emulation functions for code size, we would want to give them the GL_TRACK_ERRORS disabled treatment, as well as optimize other code locations around this for size as well.
There was a problem hiding this comment.
Oh yeah, I forget that creates now garbage too.. doh!
sbc100
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the largest remaining source of per-frame JS garbage in Unity's WebGL 2 backend.