[stdlib] Improve the Time library for Luna #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
suggested changes
Jan 10, 2018
stdlib/Std/src/Base.luna
Outdated
| ## Returns a TimeInterval with the length of `self` days. | ||
| def days: self*24 . hours | ||
| ## Returns a TimeInterval with the length of `self` weeks. | ||
| def days: self*7 . days |
There was a problem hiding this comment.
This recursion never ends.
stdlib/Std/src/Base.luna
Outdated
| ## Returns a TimeInterval with the length of `self` fortnights. | ||
| def fortnights: self*2 . weeks | ||
| ## An alias for `miliseconds` | ||
| def milisecond: self.miliseconds |
There was a problem hiding this comment.
Remove the singulars, this is too much
stdlib/Std/src/Base.luna
Outdated
| ## Returns a TimeInterval with the length of `self` weeks. | ||
| def days: self*7 . days | ||
| ## Returns a TimeInterval with the length of `self` fortnights. | ||
| def fortnights: self*2 . weeks |
There was a problem hiding this comment.
Fortnight is not that useful. But a month or a year would be much more welcome :)
|
Ooops, why did I merge and not rebase ;( Ha, fixed! 🥇 |
728338a
to
080a2b6
Compare
kustosz
approved these changes
Jan 14, 2018
stdlib/Std/src/Time.luna
Outdated
|
|
||
| def midnight: TimeOfDayVal 0 0 0.0 | ||
|
|
||
| def midday: TimeOfDayVal 12 0 0.0 |
0ca9800
to
9619838
Compare
|
@kustosz I removed the tests, because it turned out they made little sense. But fixed all the errors I encountered along the way. I think I'll merge this one and open a new one to create some tests. |
iamrecursion
pushed a commit
that referenced
this pull request
Aug 10, 2018
turion
pushed a commit
to turion/luna
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{beginning, end}Of{Day, Month, Year}Std.hsfile, just for (my) convenience.NOTE: I decided to do the timezone support as a separate PR, this is big enough.