[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Runtime Version Manager with Project Manager #1285

Merged
merged 18 commits into from
Nov 16, 2020

Conversation

radeusgd
Copy link
Member
@radeusgd radeusgd commented Nov 12, 2020

Pull Request Description

Related to #1153. Does not close it, because this is the first of two PRs.

This PR introduces the basic integration of Project Manager and Runtime Version Manager and implements handlers for most newly added protocol methods.

It does not however update the way how the Language Server is started, i.e. while other features use the new version management, with this PR the LS is still launched in the old way. As this is quite complex, that will be handled in the next PR.

Important Notes

  • Due to Runtime Version Manager introducing our own logging service, but language server that we depend on (as above) uses logback, there are warnings about multiple available implementations. These warnings will go away with the second PR, as we will remove the dependency to language-server and so logback will go away from project-manager's classpath.
  • Made mechanism for reporting status of TaskProgress and resource locks more general.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd added Type: Enhancement -tooling Category: tooling p-high Should be completed in the next sprint labels Nov 12, 2020
@radeusgd radeusgd self-assigned this Nov 12, 2020
@radeusgd radeusgd marked this pull request as ready for review November 12, 2020 16:56
@radeusgd radeusgd force-pushed the wip/rw/version-management-in-pm branch from 40360e2 to dae3c42 Compare November 13, 2020 08:50
Copy link
Contributor
@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, with some minor remarks

@radeusgd radeusgd force-pushed the wip/rw/version-management-in-pm branch from dae3c42 to 026a072 Compare November 13, 2020 18:08
Copy link
Contributor
@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not done a detailed review as that is for @4e6.

@radeusgd radeusgd force-pushed the wip/rw/version-management-in-pm branch from df0b149 to 00fc3a2 Compare November 16, 2020 15:26
@radeusgd radeusgd merged commit 4d5f794 into main Nov 16, 2020
@radeusgd radeusgd deleted the wip/rw/version-management-in-pm branch November 16, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants