-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Runtime Version Manager with Project Manager #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
Type: Enhancement
-tooling
Category: tooling
p-high
Should be completed in the next sprint
labels
Nov 12, 2020
radeusgd
requested review from
4e6,
iamrecursion,
kustosz and
lolczak
as code owners
November 12, 2020 16:56
radeusgd
force-pushed
the
wip/rw/version-management-in-pm
branch
from
November 13, 2020 08:50
40360e2
to
dae3c42
Compare
4e6
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, with some minor remarks
lib/scala/json-rpc-server-test/src/main/scala/org/enso/jsonrpc/test/JsonRpcServerTestKit.scala
Show resolved
Hide resolved
...nager/src/main/scala/org/enso/projectmanager/requesthandler/EngineListAvailableHandler.scala
Outdated
Show resolved
Hide resolved
...a/project-manager/src/main/scala/org/enso/projectmanager/requesthandler/RequestHandler.scala
Outdated
Show resolved
Hide resolved
...ersion-manager-test/src/main/scala/org/enso/runtimeversionmanager/test/FakeEnvironment.scala
Outdated
Show resolved
Hide resolved
radeusgd
force-pushed
the
wip/rw/version-management-in-pm
branch
from
November 13, 2020 18:08
dae3c42
to
026a072
Compare
iamrecursion
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not done a detailed review as that is for @4e6.
radeusgd
force-pushed
the
wip/rw/version-management-in-pm
branch
from
November 16, 2020 15:26
df0b149
to
00fc3a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Related to #1153. Does not close it, because this is the first of two PRs.
This PR introduces the basic integration of Project Manager and Runtime Version Manager and implements handlers for most newly added protocol methods.
It does not however update the way how the Language Server is started, i.e. while other features use the new version management, with this PR the LS is still launched in the old way. As this is quite complex, that will be handled in the next PR.
Important Notes
Checklist
Please include the following checklist in your PR: