[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Locations in Desugared Lambdas #1522

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix Locations in Desugared Lambdas #1522

merged 1 commit into from
Feb 26, 2021

Conversation

4e6
Copy link
Contributor
@4e6 4e6 commented Feb 26, 2021

Pull Request Description

close #1511

Fixes points 1-5 in #1511. The issue happened because the runtime did not send the updates for lambda expressions.
This was because the locations in lambdas were missing and therefore the lambdas were invisible to the runtime instrumentation.

This PR only fixes the lambda expressions, but there is a similar issue with the operator sections #1521

Changelog

  • fix: reattach original locations during the lambda desugaring

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-highest Should be completed ASAP labels Feb 26, 2021
@4e6 4e6 self-assigned this Feb 26, 2021
Copy link
Contributor
@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice, clean fix for the issue! Great stuff!

@4e6 4e6 merged commit 0c5a362 into main Feb 26, 2021
@4e6 4e6 deleted the wip/db/lambda-visualizations branch February 26, 2021 09:59
iamrecursion pushed a commit that referenced this pull request Feb 26, 2021
Reattach original locations during
the lambda desugaring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with nodes containing _
2 participants